[PATCH] D39357: Filter out invalid 'target' items from being passed to LLVM

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 26 18:34:15 PDT 2017


erichkeane created this revision.

Craig noticed that CodeGen wasn't properly ignoring the
values sent to the target attribute.  This patch ignores
them.

This patch also sets the 'default' for this checking to 
'supported', since only X86 has implemented the support
for checking valid CPU names and Feature Names.

One test was changed to i686, since it uses a lakemont,
which would otherwise be prohibited in x86_64.


https://reviews.llvm.org/D39357

Files:
  include/clang/Basic/TargetInfo.h
  lib/Basic/Targets/X86.cpp
  lib/CodeGen/CGCall.cpp
  lib/CodeGen/CodeGenModule.cpp
  test/CodeGen/attr-target-x86.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39357.120528.patch
Type: text/x-patch
Size: 6299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171027/db27cb7c/attachment-0001.bin>


More information about the cfe-commits mailing list