[PATCH] D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang

Yuka Takahashi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 26 13:23:33 PDT 2017


yamaguchi created this revision.

Previously, we passed "#" to --autocomplete to indicate to enable cc1
flags. For example, when -cc1 or -Xclang was passed to bash, bash
executed `clang --autocomplete=#-<flag they want to complete>`.

However, this was not a good implementation because it depends -Xclang
and -cc1 parsing to shell. So I changed this to pass all flags shell
has, so that Clang can handle them internally.

I'll leave exsisting testcase as it is inorder to test backward
compatibility.


https://reviews.llvm.org/D39342

Files:
  clang/lib/Driver/Driver.cpp
  clang/test/Driver/autocomplete.c
  clang/utils/bash-autocomplete.sh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39342.120474.patch
Type: text/x-patch
Size: 5350 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171026/d03d1b95/attachment-0001.bin>


More information about the cfe-commits mailing list