[PATCH] D39310: [CGBlocks] Improve line info in backtraces containing *_helper_block

[Adrian Prantl via Phabricator via cfe-commits]

aprantl added a comment.

Thanks! This looks generally good, I have one pending question inline.



================
Comment at: test/CodeGenObjC/debug-info-blocks.m:13
 
-// rdar://problem/14386148
-// Test that we don't emit bogus line numbers for the helper functions.
-// Test that we do emit scope info for the helper functions.
+// rdar://problem/32907581
+// Test that we do emit scope info for the helper functions, and that the
----------------
We nowadays usually try to avoid rdar links in anything but commit messages because it is not helpful information for the LLVM community. It's better to just describe the issue at hand (which you are doing!) or create a PR with that contents and link to it.


================
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
 // CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
 // CHECK-NOT: ret
 // CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]+]]
----------------
What's the location used for the ret? I think it should also be` ![[DBG_LINE]]` since we are not actually executing the block.


https://reviews.llvm.org/D39310