[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 26 06:46:04 PDT 2017


lebedev.ri added inline comments.


================
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:499
+      functionDecl(
+          allOf(isDefinition(), unless(anyOf(isInstantiated(), isImplicit()))))
+          .bind("func"),
----------------
aaron.ballman wrote:
> Since we're restricting this, might as well add deleted and defaulted functions to the list of `unless` items (as I think those are still definitions).
Good idea!
It seems only the deleted were still matched, not defaulted.


Repository:
  rL LLVM

https://reviews.llvm.org/D36836





More information about the cfe-commits mailing list