[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

[Ivan Kosarev via Phabricator via cfe-commits]

kosarev added a comment.

Yes, I don't like it too when it comes to comparing pointers to metadata nodes in an attempt to figure out what kind of access we are dealing with.

What concerns me is that there may be other kinds of TBAA descriptors that are neither ordinary nor may-alias ones. For example, at some point we will need to distinct TBAA descriptors for accesses to direct and indirect union members, because they require special processing.

What if we replace the may-alias flag with an enumeration? Something like this:

  enum class TBAAAccessKind {
    Ordinary,
    MayAlias,
  };


Repository:
  rL LLVM

https://reviews.llvm.org/D39008