[PATCH] D39308: [libcxx] Keep track of heap allocated regex states

Tim Shen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 25 15:55:00 PDT 2017


timshen created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.

Build abstraction on regex's allocation

This fixes a fuzzer crasher from a huge input (provided by Marshall), which seems to be a stackoverflow during destruction. However, I can't reproduce Marshall's crasher even before the change.

No new tests are added, but all old tests pass. I didn't really run valgrind on tests to check for memory leak, as the new allocation is basically correct by construction (only one call site uses `new`, no explicit `delete` calls).


https://reviews.llvm.org/D39308

Files:
  libcxx/include/regex

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39308.120332.patch
Type: text/x-patch
Size: 14659 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171025/4f040e1f/attachment.bin>


More information about the cfe-commits mailing list