[PATCH] D39251: [libunwind] Fix building for ARM with dwarf exception handling

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd added a comment.

Whats the motivation for adding DWARF based unwinding on ARM?  What environment is using this?



================
Comment at: src/Registers.hpp:1342
   }
+  static int  lastDwarfRegNum() { return 287; }
 
----------------
Can we not use `_LIBUNWIND_HIGHEST_DWARF_REGISTER` here?


================
Comment at: src/UnwindLevel1.c:79
       _LIBUNWIND_TRACE_UNWINDING(
           "unwind_phase1(ex_ojb=%p): pc=0x%" PRIx64 ", start_ip=0x%" PRIx64
           ", func=%s, lsda=0x%" PRIx64 ", personality=0x%" PRIx64 "",
----------------
Please convert these to `%p` instead.  The casting and conversion is kinda ... unnecessary.


https://reviews.llvm.org/D39251