[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 23:54:24 PDT 2017


rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGExpr.cpp:2171
+                                     LValueBaseInfo *ReferenceeBaseInfo,
+                                     TBAAAccessInfo *ReferenceeTBAAInfo) {
+  llvm::LoadInst *Load = Builder.CreateLoad(ReferenceAddr, IsVolatile);
----------------
"Pointee" would be better than "Referencee", please.

Should this just take an LValue?  The first five arguments here are basically an LValue.


Repository:
  rL LLVM

https://reviews.llvm.org/D39177





More information about the cfe-commits mailing list