[PATCH] D39220: [Analyzer] Store BodyFarm in std::unique_ptr

Zhihao Yuan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 19:50:44 PDT 2017


lichray added inline comments.


================
Comment at: lib/Analysis/AnalysisDeclContext.cpp:606
 
-AnalysisDeclContextManager::~AnalysisDeclContextManager() {
-  if (BdyFrm)
-    delete BdyFrm;
-}
+AnalysisDeclContextManager::~AnalysisDeclContextManager() {}
 
----------------
Why having empty user-defined dtor?  This class has no vtbl; deleting the dtor declaration in `AnalysisDeclContext.h` should work.


https://reviews.llvm.org/D39220





More information about the cfe-commits mailing list