[PATCH] D39161: [bindings] remove unique_external test failure
Masud Rahman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Oct 21 14:08:08 PDT 2017
frutiger created this revision.
In SVN r314037, linkage determination of a symbol was significantly
refactored. This resulted in extern anonymous namespace declarations to
no longer be considered 'unique_external'. This ultimately broke a test
in the Python bindings.
This commit removes the 'unique_external' test case.
https://reviews.llvm.org/D39161
Files:
bindings/python/tests/cindex/test_linkage.py
Index: bindings/python/tests/cindex/test_linkage.py
===================================================================
--- bindings/python/tests/cindex/test_linkage.py
+++ bindings/python/tests/cindex/test_linkage.py
@@ -12,7 +12,6 @@
tu = get_tu("""
void foo() { int no_linkage; }
static int internal;
-namespace { extern int unique_external; }
extern int external;
""", lang = 'cpp')
@@ -22,9 +21,6 @@
internal = get_cursor(tu.cursor, 'internal')
assert internal.linkage == LinkageKind.INTERNAL
- unique_external = get_cursor(tu.cursor, 'unique_external')
- assert unique_external.linkage == LinkageKind.UNIQUE_EXTERNAL
-
external = get_cursor(tu.cursor, 'external')
assert external.linkage == LinkageKind.EXTERNAL
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39161.119769.patch
Type: text/x-patch
Size: 759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171021/7b4378e5/attachment-0001.bin>
More information about the cfe-commits
mailing list