[PATCH] [bindings] fix TLS test failure

Masud Rahman via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 21 13:10:19 PDT 2017


Since cfe commit r237337, '__declspec(thread)' and 'thread_local' have
been the same since MSVC 2015.  i.e. they are both considered to supply
a dynamic TLS kind, not a static TLS kind.

This test originally did not specify which version of MS compatibility
to assume.  As a result, the test was brittle, since changing the
default compatibility version could break the test.

This commit adds a specific version when building up the flags used to
parse the translation unit, and tests both versions.
---
 bindings/python/tests/cindex/test_tls_kind.py | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bindings-fix-TLS-test-failure.patch
Type: text/x-patch
Size: 1410 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171021/40177183/attachment.bin>


More information about the cfe-commits mailing list