[PATCH] D38549: [clang-tidy] Link targets and Asm parsers

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/hicpp-no-assembler.cpp:13-16
+  _asm {
+    mov al, 2;
+    // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: do not use inline assembler in safety-critical code [hicpp-no-assembler]
+  }
----------------
alexfh wrote:
> Will this compile on linux and mac? If no, maybe a separate test just for windows is the way to go.
... answering my own question: no, it doesn't compile on linux (https://godbolt.org/g/9HVvjp).

Please add a separate test guarded by `REQUIRES: system-windows` and ensure it breaks before your patch and passes with it.


https://reviews.llvm.org/D38549