[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

Don Hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 20 06:57:08 PDT 2017


hintonda added a comment.

In https://reviews.llvm.org/D36347#901885, @zturner wrote:

> One possible reason for why this never got any traction is that `lldb-commits` wasn't added as a subscriber.  While it's true that the tagged people should have chimed in, having the whole commits list will get some more visibility.  I never saw this come to my inbox.
>
> I think this would be most suitable in the `lldb/examples` folder.
>
> I can't really review this thoroughly, because it relies on a bash script, and I use Windows where we bash isn't really a thing.  My bash is rusty, but it looks like you're embedding a python script in the bash script?  It might be good if this were just an lldb script command.  Take a look at `command script add` in LLDB, and in the `examples` folder for some examples of existing commands that work this way.  The nice thing about doing it this way is that you could just be inside LLDB and write `(lldb) break-diag -Wcovered-switch`, for example, which would be a much tighter integration with the debugger.


Thanks for taking a look.

I mainly work on *nix systems, hence the initial shell script, but if there's an interest, I'll be happy to convert it to a single python script as you suggest, and resubmit it as a patch to lldb.

Thanks again...


https://reviews.llvm.org/D36347





More information about the cfe-commits mailing list