[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr
Gábor Horváth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 19 02:44:18 PDT 2017
xazax.hun added inline comments.
================
Comment at: lib/AST/ASTImporter.cpp:5476
+
+ for (unsigned ai = 0, ae = NumArgs; ai != ae; ++ai) {
+ Expr *FromArg = CE->getArg(ai);
----------------
Use uppercase variable names.
================
Comment at: lib/AST/ASTImporter.cpp:5477
+ for (unsigned ai = 0, ae = NumArgs; ai != ae; ++ai) {
+ Expr *FromArg = CE->getArg(ai);
+ Expr *ToArg = Importer.Import(FromArg);
----------------
I would eliminate this local variable.
https://reviews.llvm.org/D38694
More information about the cfe-commits
mailing list