[PATCH] D38843: [ASTImporter] Support importing CXXPseudoDestructorExpr
Gábor Horváth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 19 02:37:12 PDT 2017
xazax.hun added inline comments.
================
Comment at: lib/AST/ASTImporter.cpp:5549
+ Expr *BaseE = Importer.Import(E->getBase());
+ if (!BaseE)
+ return nullptr;
----------------
Does `E->getBase()` guaranteed to return non-null? What happens when this node was constructed using EmptyShell? Shouldn't we check for that somehow? When can that happen?
https://reviews.llvm.org/D38843
More information about the cfe-commits
mailing list