[PATCH] D39064: implement __has_unique_object_representations

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: lib/Parse/ParseExpr.cpp:719
 ///                   '__is_union'
+///                   '__has_unique_object_representations'   [MS]
 ///
----------------
STL_MSFT wrote:
> Should this be marked as MS if it's cross-vendor?
Ah, right :)  I didn't discover the GCC version until later, and must have forgotten this.


================
Comment at: test/SemaCXX/type-traits.cpp:2403
+static_assert(has_unique_object_representations<bool>::value, "yes, all integral types");
+static_assert(has_unique_object_representations<char>::value, "and pointer to members");
+static_assert(has_unique_object_representations<signed char>::value, "and pointer to members");
----------------
STL_MSFT wrote:
> char is a pointer to member! What a world. (ditto below)
What a world indeed!


https://reviews.llvm.org/D39064