[PATCH] D39035: Unnamed bitfields don't block constant evaluation of constexpr constructors

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from some minor nits, LGTM!



================
Comment at: test/SemaCXX/constant-expression-cxx11.cpp:1924
+
+
+  struct HasUnnamedBitfield {
----------------
Can remove the spurious newline.


================
Comment at: test/SemaCXX/warn-global-constructors.cpp:130
+
+namespace HasUnnamedBitfield {
+  struct HasUnnamedBitfield {
----------------
Does this namespace require a name? If so, can it be named different than the struct declared within it?


================
Comment at: test/SemaCXX/warn-global-constructors.cpp:148
+}
\ No newline at end of file

----------------
Please ensure the file retains its newline.


Repository:
  rL LLVM

https://reviews.llvm.org/D39035