[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Have a question on the behavior here, see inline.



================
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:299
   if (!ThrowType)
     return false;
   if (ThrowType->isReferenceType())
----------------
The other potential fix here is to simply change this line here to "return true;".  This would result the warning being suppressed on 'rethrow' if there is any catch statements. 

I wonder what the opinion of the reviewers is on this one.


================
Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:244
+// exception, catch(...) catches everything. 
+void o_ShouldDiag() noexcept {
   try {
----------------
Doh, I should have changed the name here... Still want your feedback on above though.


https://reviews.llvm.org/D39013