[PATCH] D38599: Remove warnings for dynamic_cast fallback.
Dan Albert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 16 17:00:27 PDT 2017
danalbert added a comment.
In https://reviews.llvm.org/D38599#899196, @howard.hinnant wrote:
> Fwiw, I wrote this code. All of that "fallback" stuff was written to make customer code that was incorrect, but working on OS X -version-that-used-libsupc++ continue to work. I.e. to be a crutch for incorrect code. It should all be removed if you no longer want to provide such a crutch.
Android may end up wanting to use it for the same reason. I've backed it out for now, but it may end up being something we need since a fair number of NDK users (majority, probably) use libsupc++ and that might be a point of pain in migrating to libc++abi. Other Linux distros may want it as well, so probably worth leaving the code around.
https://reviews.llvm.org/D38599
More information about the cfe-commits
mailing list