[PATCH] D38868: [OpenCL] Restrict swizzle length check to OpenCL mode
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 16 04:43:09 PDT 2017
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: test/SemaOpenCL/vector_swizzle_length.cl:7
void foo() {
- float8 f2 = (float8)(0, 0, 0, 0, 0, 0, 0, 0);
+ float8 f2 = (float8){0, 0, 0, 0, 0, 0, 0, 0};
----------------
bruno wrote:
> Anastasia wrote:
> > Even though this works in Clang, ideally OpenCL vector literal is with parenthesis (see s6.1.6).
> Ok. I changed this to avoid warnings in C mode. Gonna change it back,
Can you undo this change please before committing. Thanks!
https://reviews.llvm.org/D38868
More information about the cfe-commits
mailing list