[PATCH] D38882: [clang-rename] Add function unit tests.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 16 02:48:26 PDT 2017


ioeric accepted this revision.
ioeric added a comment.

Still LGTM



================
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:469
+          // name.
+          // FIXME: Consider using using-decls to shorten the namespace
+          // qualifers.
----------------
The current behavior looks fine to me, but I'm not sure if this is a right `FIXME`? Basically, I think we want to be able to get the real `DeclContext` for the symbol reference here right?


https://reviews.llvm.org/D38882





More information about the cfe-commits mailing list