[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 16 00:41:58 PDT 2017


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/clangd/authority-less-uri.test:33
 {"jsonrpc":"2.0","id":3,"method":"shutdown"}
+# CHECK: {"jsonrpc":"2.0","id":3,"result":null}
+Content-Length: 33
----------------
Having the shutdown/exit boilerplate in every test seems unfortunate.
(I realize this isn't new here, but it's getting worse!)

Does clangd exit cleanly on stdin EOF? If it could be made to do so, maybe we could just have e.g. the initialize test do the full sequence, and the other tests omit shutdown.


https://reviews.llvm.org/D38939





More information about the cfe-commits mailing list