[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 08:35:39 PDT 2017


lebedev.ri updated this revision to Diff 118793.
lebedev.ri marked 4 inline comments as done.
lebedev.ri added a comment.

@rsmith, thank you for the review!

Rebased, address review notes, simplified all the things even further.

Testing:

- `$ ninja check-clang-sema check-clang-semacxx`
- Stage 2 build (still good, no issues/warnings)


Repository:
  rL LLVM

https://reviews.llvm.org/D38101

Files:
  docs/ReleaseNotes.rst
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticSemaKinds.td
  lib/Sema/SemaChecking.cpp
  test/Sema/outof-range-constant-compare.c
  test/Sema/tautological-constant-compare.c
  test/Sema/tautological-unsigned-zero-compare.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38101.118793.patch
Type: text/x-patch
Size: 42507 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171012/bd6c93dd/attachment-0001.bin>


More information about the cfe-commits mailing list