[PATCH] D33989: [OpenCL] Allow targets to select address space per type

NAKAMURA Takumi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 12 03:01:08 PDT 2017


chapuni added inline comments.


================
Comment at: cfe/trunk/lib/Basic/TargetInfo.cpp:351
 
+LangAS::ID TargetInfo::getOpenCLTypeAddrSpace(const Type *T) const {
+  auto BT = dyn_cast<BuiltinType>(T);
----------------
Excuse me for old commit, I think it might be layering violation.
Could we avoid using AST/Type here?


Repository:
  rL LLVM

https://reviews.llvm.org/D33989





More information about the cfe-commits mailing list