[PATCH] D38816: Convert clang::LangAS to a strongly typed enum
Alexander Richardson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 11 14:39:10 PDT 2017
arichardson added inline comments.
================
Comment at: include/clang/Basic/AddressSpaces.h:51
+namespace LanguageAS {
/// The type of a lookup table which maps from language-specific address spaces
----------------
jlebar wrote:
> I wonder if you need this namespace? LangAS right next to LanguageAS reads strangely to me -- "what's the difference?".
>
> I guess you'd need to rename Map and fromTargetAS, but the other two members are probably OK?
The only reason I added this namespace is that I wasn't sure whether having those functions in the clang namespace is acceptable.
Not quite sure what to call the functions though. `langASFromTargetAS`?
Repository:
rL LLVM
https://reviews.llvm.org/D38816
More information about the cfe-commits
mailing list