r315492 - [Analyzer] Fix introduced regression: properly check for nullable attribute.

George Karpenkov via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 11 12:13:15 PDT 2017


Author: george.karpenkov
Date: Wed Oct 11 12:13:15 2017
New Revision: 315492

URL: http://llvm.org/viewvc/llvm-project?rev=315492&view=rev
Log:
[Analyzer] Fix introduced regression: properly check for nullable attribute.

Modified:
    cfe/trunk/lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.cpp

Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.cpp?rev=315492&r1=315491&r2=315492&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.cpp Wed Oct 11 12:13:15 2017
@@ -122,7 +122,8 @@ bool NonnullStringConstantsChecker::isSt
     return true;
 
   if (auto *T = dyn_cast<ObjCObjectPointerType>(Ty)) {
-    return T->getInterfaceDecl()->getIdentifier() == NSStringII;
+    return T->getInterfaceDecl() &&
+      T->getInterfaceDecl()->getIdentifier() == NSStringII;
   } else if (auto *T = dyn_cast<TypedefType>(Ty)) {
     return T->getDecl()->getIdentifier() == CFStringRefII;
   }




More information about the cfe-commits mailing list