[PATCH] D37856: [refactor] add support for refactoring options

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
     Rules.push_back(createRefactoringActionRule<RenameOccurrences>(
-        SymbolSelectionRequirement()));
+        SymbolSelectionRequirement(), OptionRequirement<NewNameOption>()));
     return Rules;
----------------
arphaman wrote:
> hokein wrote:
> > Thought it a bit more: it requires all of the requirements are satisfied, I think we need to support "one-of" option. For example,  we have two option "-a" and "-b",  only one of them is allowed to be present at the same time.
> That should be straightforward enough to implement, either with a custom class or with a built-in requirement class. I'll probably add a builtin one when the need comes up.
Thanks. I'm asking it because I plan to add the `-qualified-name` option to the clang-refactor rename subtool. And obviously "-qualified-name" can not be present with "-selection".


Repository:
  rL LLVM

https://reviews.llvm.org/D37856