[PATCH] D38599: Remove warnings for dynamic_cast fallback.

Dan Albert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 10 15:53:26 PDT 2017


danalbert added a comment.

In https://reviews.llvm.org/D38599#893903, @jroelofs wrote:

> That reminds me... this does need a testcase or two.


Oh, also, any test I add is going to fail, since the case I'm trying to account for here is not the default behavior.

I could make the more invasive change and actually make libc++abi use the fallback by default like libsupc++ does, but I was willing to settle for just not spamming the user with warnings that they can't do anything about.


Repository:
  rL LLVM

https://reviews.llvm.org/D38599





More information about the cfe-commits mailing list