[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 9 14:19:21 PDT 2017


compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

I think that the problem is that we are using the generic register name, but we need to use the target specific register name.  On x86, EIP/ESP are swapped.  We should also have a test case for this.  I had reduced this down to a simpler test case of:

  void f(int,int,int,int,int,int,int,int,int);
  
  int main() {
    try {
      f(0,1,2,3,4,5,6,7,8);
    } catch (int) {
      return 0;
    }
    return 1;
  }


https://reviews.llvm.org/D38680





More information about the cfe-commits mailing list