[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: src/AddressSpace.hpp:521
                                                 unw_word_t *offset) {
-#ifndef _LIBUNWIND_IS_BAREMETAL
+#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32)
   Dl_info dyldInfo;
----------------
jroelofs wrote:
> Would it work to implement the win32 side of this via `SymFromAddr`?
Hmm, I guess that would work.


================
Comment at: src/UnwindRegistersRestore.S:29
 #  +                       +
+#if !defined(_WIN32)
   movl   4(%esp), %eax
----------------
jroelofs wrote:
> Please invert the condition, and swap the if/else on this. That will make it more straightforward to adjust this for other platforms later.
Ok, will do.


https://reviews.llvm.org/D38679