[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: src/AddressSpace.hpp:388-389
+          found_obj = true;
+      } else if (!strncmp((const char *)pish->Name, ".eh_frame",
+                          IMAGE_SIZEOF_SHORT_NAME)) {
+        info.dwarf_section = begin;
----------------
rnk wrote:
> ".eh_frame" is 9 characters, right? I thought mingw linkers took sections with long names and moved them to an extended symbol table. Does that not apply to .eh_frame?
Yes, they do, so this actually only matches `.eh_fram`. I didn't yet look at how to navigate the IMAGE_*_HEADERS structs to find the coresponding full long name.


https://reviews.llvm.org/D38679