[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 9 11:51:29 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D38646#892246, @STL_MSFT wrote:

> FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, the first toolset update. 1912 will be the value for VS 2017 15.5, the second toolset update.


Yep. The initial draft of this patch had the wrong commit message, but everything is fixed in the committed version.

I had 1910 installed on my machine locally, and spent this morning untangling that. Apparently now you have to install updates through the VS "Tools -> Extesions & Updates -> mumble" menu. Downloading and running the VS update 3 installer isn't enough.


Repository:
  rL LLVM

https://reviews.llvm.org/D38646





More information about the cfe-commits mailing list