[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

I'm missing some context for this one:

- what's the goal? Make the code read more naturally, change the async model, or something else?
- what's the end state for codeComplete specifically? will we switch to the new overload and delete the other, or is makeFutureAPIFromCallback here to stay?


https://reviews.llvm.org/D38629