[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 6 13:52:34 PDT 2017


rnk created this revision.

This raises our default past 1900, which controls whether char16_t is a
builtin type or not.

Implements PR34243


https://reviews.llvm.org/D38646

Files:
  clang/lib/Driver/ToolChains/MSVC.cpp


Index: clang/lib/Driver/ToolChains/MSVC.cpp
===================================================================
--- clang/lib/Driver/ToolChains/MSVC.cpp
+++ clang/lib/Driver/ToolChains/MSVC.cpp
@@ -1266,9 +1266,8 @@
   if (MSVT.empty() &&
       Args.hasFlag(options::OPT_fms_extensions, options::OPT_fno_ms_extensions,
                    IsWindowsMSVC)) {
-    // -fms-compatibility-version=18.00 is default.
-    // FIXME: Consider bumping this to 19 (MSVC2015) soon.
-    MSVT = VersionTuple(18);
+    // -fms-compatibility-version=19.10 is default, aka 2017
+    MSVT = VersionTuple(19, 10);
   }
   return MSVT;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38646.118073.patch
Type: text/x-patch
Size: 621 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171006/d882ad61/attachment.bin>


More information about the cfe-commits mailing list