[PATCH] D38606: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 5 20:16:32 PDT 2017

Previous message: [PATCH] D38606: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size
Next message: [PATCH] D38606: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

rjmccall added a comment.

I don't see any reason not to use linkonce_odr + hidden even outside of -Oz.  Otherwise LGTM.


https://reviews.llvm.org/D38606

Previous message: [PATCH] D38606: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size
Next message: [PATCH] D38606: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list