[PATCH] D38596: Implement attribute target multiversioning

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 5 18:36:55 PDT 2017


echristo added a comment.

This generally works for me modulo the things that Hal has mentioned. You'll probably want to add Richard to the review list for the Sema bits as well.

Thanks!



================
Comment at: lib/Sema/SemaDecl.cpp:3214
       if (!isFriend && NewMethod->getLexicalDeclContext()->isRecord() &&
-          !IsClassScopeExplicitSpecialization) {
+          !IsClassScopeExplicitSpecialization ) {
         //    -- Member function declarations with the same name and the
----------------
Extra whitespace.


https://reviews.llvm.org/D38596





More information about the cfe-commits mailing list