[PATCH] D37891: Driver: hoist the `wchar_t` handling to the driver

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 5 11:45:28 PDT 2017


rnk added inline comments.


================
Comment at: lib/Basic/TargetInfo.cpp:29
+namespace {
+TargetInfo::IntType GetDefaultWCharType(const llvm::Triple &T) {
+  const llvm::Triple::ArchType Arch = T.getArch();
----------------
How is this better than what we had before? It's totally inconsistent with our existing strategy for figuring out type widths and sizes. Our current approach can be extended for new targets, this requires modifying shared TargetInfo code. This refactoring *should* be NFC anyway, so if we did want to do it, we'd want to split it out.


https://reviews.llvm.org/D37891





More information about the cfe-commits mailing list