[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a reviewer: dberlin.
aaron.ballman added a subscriber: dberlin.
aaron.ballman added a comment.

Adding @dberlin for licensing discussion questions.



================
Comment at: LICENSE.TXT:64
 clang-tidy          clang-tidy/hicpp
+clang-tidy          clang-tidy/readability/FunctionCognitiveComplexityCheck.LICENSE.txt
----------------
This should point to a directory instead of an individual file.


================
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.LICENSE.txt:2
+------------------------------------------------------------------------------
+clang-tidy Cognitive Complexity Check
+------------------------------------------------------------------------------
----------------
I think that this file should be a general LICENSE.TXT instead of a tied to a specific file name. The license is for the algorithm, not for the file name.


================
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.LICENSE.txt:13
+
+From: Olivier Gaudin <olivier.gaudin at sonarsource.com>
+Date: Tue, 01 Aug 2017 07:06:11 +0000
----------------
This isn't actually a license, however. I think we need to ask sonarsource either for a license statement they're comfortable with, or approach them with one in hand that they can approve. However, @dberlin might have more input here.


Repository:
  rL LLVM

https://reviews.llvm.org/D36836