[PATCH] D38583: [clangd] Added async API to run code completion.
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 5 08:11:53 PDT 2017
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
================
Comment at: clangd/ClangdServer.h:236-237
+ ///
+ /// Request is processed asynchronously, you can use returned future to wait
+ /// for results of async request.
+ ///
----------------
ilya-biryukov wrote:
> klimek wrote:
> > Extra space before asynchronously.
> > Replace first ',' with ';'
> > ... wait for the results of the async request...
> Split into two sentences on `,` instead of replacing it with `;`. Feels even better.
..."the" returned future...
https://reviews.llvm.org/D38583
More information about the cfe-commits
mailing list