[PATCH] D37826: Refine generation of TBAA information in clang

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 4 19:47:03 PDT 2017


rjmccall added a comment.

In https://reviews.llvm.org/D37826#888086, @kosarev wrote:

> In https://reviews.llvm.org/D37826#887820, @rjmccall wrote:
>
> > I assume I should wait on reviewing this until all of these smaller TBAA patches land?
>
>
> These small patches are actually part of this diff. Generally, It depends on how you would like it: if you can review this re-based version as a whole, then that would save us some time.
>
> Otherwise, you may want to proceed by smaller pieces, in which case https://reviews.llvm.org/D38503 is the next proposed piece to review.
>
> Alternatively, if https://reviews.llvm.org/D38503 looks too complicated, please let me know and I will break it down into even smaller patches.
>
> Or, if acceptable, I could commit a series of really small and simple diffs that all result in what is presented in https://reviews.llvm.org/D38126 and rely on post-commit reviews.
>
> I'm fine with either way, provided the changes go to the mainline in time manner.
>
> Thanks a lot for reviewing!


I'll let you rebase this on top of the https://reviews.llvm.org/D38503 when you commit it, and then I'll just review this directly.  Thanks a lot for splitting it up!

John.


https://reviews.llvm.org/D37826





More information about the cfe-commits mailing list