[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 4 19:43:20 PDT 2017


rjmccall added a comment.

Are you sure it's a good idea to not print the address space when it's implicit?  Won't that often lead to really confusing diagnostics?

Also, we do already have a way of expressing that an extended qualifier was explicit: AttributedType.  We have very similar sorts of superficial well-formedness checks to what I think you're trying to do in ObjC ARC.


https://reviews.llvm.org/D35082





More information about the cfe-commits mailing list