[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 4 12:31:06 PDT 2017


lebedev.ri added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:8697
+
+  return true;
 }
----------------
If the diagnostic we are about to output is disabled, should we still `return true;` and suppress potential `-Wsign-compare` warning?


Repository:
  rL LLVM

https://reviews.llvm.org/D38101





More information about the cfe-commits mailing list