[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 4 06:03:44 PDT 2017
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a small nit, this LGTM, thanks!
================
Comment at: clang-tidy/readability/NamespaceCommentCheck.cpp:102-105
+ auto TextRange =
+ Lexer::getAsCharRange(SourceRange(NestedNamespaceBegin, LBracketLocation),
+ Sources, getLangOpts());
+ auto NestedNamespaceName =
----------------
These should not use `auto` since the type is not explicitly spelled out in the initialization.
https://reviews.llvm.org/D38284
More information about the cfe-commits
mailing list