[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added inline comments.


================
Comment at: src/support/runtime/exception_msvc.ipp:31
+extern "C" {
+typedef void(__CRTDECL* terminate_handler)();
+_ACRTIMP terminate_handler __cdecl set_terminate(
----------------
smeenai wrote:
> compnerd wrote:
> > Really?  clang-format removes the space there?
> > 
> >     typedef void (__CRTDECL * terminate_handler)(void);
> > 
> > seems so much more readable.
> IIRC it's an issue with having a macro in a function pointer (`__CRTDECL`) in this case. I'll adjust the spacing manually and file a clang-format bug.
https://bugs.llvm.org/show_bug.cgi?id=34823


https://reviews.llvm.org/D38522