[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 3 17:50:00 PDT 2017


compnerd added a comment.

Why do we expect the tests to fail without vcruntime headers?



================
Comment at: src/support/runtime/exception_msvc.ipp:31
+extern "C" {
+typedef void(__CRTDECL* terminate_handler)();
+_ACRTIMP terminate_handler __cdecl set_terminate(
----------------
Really?  clang-format removes the space there?

    typedef void (__CRTDECL * terminate_handler)(void);

seems so much more readable.


https://reviews.llvm.org/D38522





More information about the cfe-commits mailing list