[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 2 07:18:22 PDT 2017


ilya-biryukov added a comment.

Thanks for fixing the last comment.
Do you want me to land this for you?



================
Comment at: clangd/GlobalCompilationDatabase.cpp:103
+      Logger.log("Failed to find compilation database for " + Twine(File) +
+                 "in overriden directory " + CompileCommandsDir.getValue() +
+                 "\n");
----------------
NIT: missing a space at the start of `"in overriden..."`. Otherwise filename will be concatenated with `"in"`


https://reviews.llvm.org/D37150





More information about the cfe-commits mailing list