[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 2 06:47:17 PDT 2017
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
Thanks. LGTM modulo minor NIT (see other inline comment).
Do you need help to land this?
================
Comment at: clangd/GlobalCompilationDatabase.cpp:102
+ if (ReturnValue == nullptr)
+ Logger.log("Failed to find compilation database for " + Twine(File) +
+ "\n");
----------------
Message should probably mention that's clangd was looking for compile commands in an overridden directory.
https://reviews.llvm.org/D37150
More information about the cfe-commits
mailing list