[PATCH] D38048: [clangd] Add textDocument/signatureHelp

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/ClangdUnit.cpp:742
+      Consumer->includeBriefComments();
+  FrontendOpts.CodeCompleteOpts.IncludeBriefComments =
+      Consumer->includeBriefComments();
----------------
Duplicated line sneaked into commit. It looks like the intention was to set `IncludeCodePatterns`.

Since we need to fill up `CodeCompleteOpts` in all callers when creating `CodeCompletionConsumer` anyway, maybe it's better to accept `CodeCompleteOpts` as a parameter?
Otherwise there's a high chance to forget syncing some of `CodeCompleteOpts` flags with the ones from `CodeCompletionConsumer` when changing the code later.


https://reviews.llvm.org/D38048