[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list=<arg1, arg2, ...> to match gcc options.
David Majnemer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Sep 30 17:44:12 PDT 2017
majnemer added inline comments.
================
Comment at: lib/CodeGen/CodeGenFunction.cpp:463
+
+ // Skip demangling if decl is extern "C"
+ if (ActualFuncDecl && !ActualFuncDecl->isExternC()) {
----------------
Is this comment still correct?
================
Comment at: lib/CodeGen/CodeGenModule.h:503
+ /// Mapping from SourceLocation to PresumedLoc FileName
+ llvm::DenseMap<unsigned, const char*> SourceLocToFileNameMap;
+
----------------
Pointers lean right.
================
Comment at: lib/CodeGen/CodeGenModule.h:1212
+ /// Get SourceLoc to FileName map cache
+ inline llvm::DenseMap<unsigned, const char*> &GetSourceLocToFileNameMap() {
+ return SourceLocToFileNameMap;
----------------
inline is redundant here.
https://reviews.llvm.org/D37624
More information about the cfe-commits
mailing list