[PATCH] D38303: [Sema] Correct IUnknown to support Unknwnbase.h Header.

NAKAMURA Takumi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 30 02:58:00 PDT 2017


chapuni added a comment.

Appeased in https://reviews.llvm.org/rL314586. I don't think my tweak would be right, though.

See;
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/6726
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/5135



================
Comment at: cfe/trunk/test/SemaCXX/ms-iunknown-template-function.cpp:18
+extern "C++" {
+// expected-warning at +1 {{__declspec attribute 'novtable'}}
+struct __declspec(uuid("00000000-0000-0000-C000-000000000046")) __declspec(novtable)
----------------
This is not seen for targeting *-win32.
I wonder why you checked it here.


Repository:
  rL LLVM

https://reviews.llvm.org/D38303





More information about the cfe-commits mailing list